[Twisted-web] Question regarding custom contextFactory for twisted.web.client.Agent

[Glyph]

> On May 21, 2017, at 9:41 PM, Jason Litzinger <jlitzingerdev at gmail.com> wrote:
> 
>> We do host a performance test suite here: http://speed.twistedmatrix.com <http://speed.twistedmatrix.com/> and the benchmarks are here https://github.com/twisted-infra/twisted-benchmarks <https://github.com/twisted-infra/twisted-benchmarks> if your test is not adequately represented in an existing benchmark.
> 
> I'm working on the previously discussed change (ticket 9138) and finally
> took a (brief) look at the benchmark suite.  Assuming master is the
> correct branch, from what I can tell the existing benchmarks for the
> Agent class use only HTTP, and the SSL tests are a lean client/server,
> not an HTTPS client/server.
> 
> Am I missing something?

A quick glance at the tests confirms your suspicions: we test TLS, and we test HTTP, but we do not test HTTP over TLS.

This is definitely something that could be rectified.

Thanks for spotting it - please submit a PR to fix it :)

-glyph