[Twisted-Python] Code review comment for http.py

[Scott, Barry]

On Saturday, 5 October 2019 04:48:03 BST Glyph wrote:
> > On Oct 4, 2019, at 4:26 AM, Scott, Barry <barry.scott at forcepoint.com>
> > wrote:
> > 
> > I see that there are duplicate lines in http.py in
> > _GenericHTTPChannelProtocol.dataReceived()
> > 
> > Notice that around line 2960 two calls to setTimeout().
> > 
> >                networkProducer.unregisterProducer()
> >                
> >                # Cancel the old channel's timeout.
> >                self._channel.setTimeout(None)
> >                
> >                # Cancel the old channel's timeout.
> >                self._channel.setTimeout(None)
> >                
> >                transport = self._channel.transport
> > 
> > Barry
> 
> Mind filing a ticket for this?  Seems like a great thing to tag with "easy"
> for new contributors :).

https://twistedmatrix.com/trac/ticket/9709

Barry
> 
> -g
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python at twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python