[Twisted-Python] Code review comment for http.py

Glyph glyph at twistedmatrix.com
Fri Oct 4 21:48:03 MDT 2019



> On Oct 4, 2019, at 4:26 AM, Scott, Barry <barry.scott at forcepoint.com> wrote:
> 
> I see that there are duplicate lines in http.py in
> _GenericHTTPChannelProtocol.dataReceived()
> 
> Notice that around line 2960 two calls to setTimeout().
> 
>                networkProducer.unregisterProducer()
> 
>                # Cancel the old channel's timeout.
>                self._channel.setTimeout(None)
> 
>                # Cancel the old channel's timeout.
>                self._channel.setTimeout(None)
> 
>                transport = self._channel.transport
> 
> 
> Barry

Mind filing a ticket for this?  Seems like a great thing to tag with "easy" for new contributors :).

-g



More information about the Twisted-Python mailing list