Changes between Version 39 and Version 40 of TwistedDevelopment


Ignore:
Timestamp:
01/05/2010 07:43:28 AM (9 years ago)
Author:
jesstess
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • TwistedDevelopment

    v39 v40  
    3737If you are interested in contributing to Twisted for the first time, consider working on an existing ticket rather than contributing a new feature.  Fixes for existing problems or implementations of already-requested features will generally take priority over new ideas.
    3838
    39 Make sure that you have written unit tests and docstrings for all code which has changed in your patch.  It works best if you use test-driven development to write your patch initially, and write your tests before your code.  (Believe me, if you write your tests after you write your code, we ''will'' know.  It's more obvious than you think.)
     39Make sure that you have written unit tests and docstrings for all code which has changed in your patch.  It works best if you use test-driven development to write your patch initially, and write your tests before your code.  (Believe me, if you write your tests after you write your code, we ''will'' know.  It's more obvious than you think.) See the [http://twistedmatrix.com/documents/current/core/development/policy/test-standard.html Twisted Unit Tests standard] for more on how to write and format your unit tests.
    4040
    4141Run the full test suite ("`trial twisted`" on the command line) ''before'' submitting your patch, and fix any problems you discover.  If a reviewer notices failing tests, they may not give your code a deep look, and you may have to wait longer for a second review.