Changes between Version 88 and Version 89 of ReviewProcess


Ignore:
Timestamp:
09/14/20 06:25:14 (17 months ago)
Author:
Tom Most
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • ReviewProcess

    v88 v89  
    5353 * Assign the ticket back to the author.
    5454 * If the change is ready for trunk, indicate so by writing "please merge" or "+1".
    55    * Alternatively, if the author does not have commit access to trunk, merge the change for them.
     55   * Alternatively, if the author does not have commit access to trunk, merge the change for them or add the "Cleared to land" label.
    5656
    5757
     
    5959
    6060 * Check in the GitHub PR that all tests are green (or the failed one are just unrelated/spurious failures)
    61  * When the PR is from a branch outside of the main repo, Buildbot builds are not automatically triggered. You will need to manually trigger them to get results. You can use the `admin/pr_as_branch` script to do this, or execute these steps manually:
    62 
    63 {{{
    64 $ # Create a new branch on the main repo, starting with Trunk.
    65 $ git checkout -b 1234-name-of-new-branch trunk
    66 
    67 $ # Get the remote code
    68 $ git pull https://github.com/CONTRIBUTOR-NAME/twisted.git NAME-OF-THE-REMOTE-BRANCH
    69 
    70 $ # Send the new branch to the repo. This will trigger Buildot.
    71 $ # Wait for the builds to end and you should start seeing reports in GitHub.
    72 $ # No need to create a new PR.
    73 $ git push --set-upstream origin 1234-name-of-new-branch
    74 }}}
    75 
    76 
    77 
    7861 * Use the GitHub merge button to merge the request, using the GitHub default commit subject, and with the standard commit format required by Twisted. See below for details.
    7962 * Alternatively, you can use the command line and merge the change into a checkout of Twisted trunk (as a merge commit, using {{{ git merge --no-ff }}}!) and commit it.