Changes between Version 43 and Version 44 of ReviewProcess


Ignore:
Timestamp:
01/24/11 02:53:36 (11 years ago)
Author:
Glyph
Comment:

Reviewers should do complete reviews.

Legend:

Unmodified
Added
Removed
Modified
  • ReviewProcess

    v43 v44  
    126126  * Does it require new documentation and examples?
    127127
     128When you're done with the review, always say what the next step should be: for example, if the author is a committer, can they commit after making a few minor fixes?  If your review feedback is more substantial, should they re-submit for another review?
     129
     130If you are officially "doing a review" - in other words, removing the review keyword - please make sure you do a complete review and look for ''all'' of these things, so that the author has as much feedback as possible to work with while their ticket is out of the review state.  If you don't have time to do a complete review, and you just notice one or two things about the ticket, just make a comment to help the future reviewer, and don't remove the review keyword, so another reviewer might have a look.  For example, say, "I just checked for a news file and I noticed there wasn't one", or, "I examined the copyright dates and one has not been updated".  If you remove the review keyword, you may substantially increase the amount of time that the author has to wait for a real, comprehensive review, which is very frustrating.
    128131
    129132=== The commit message ===