Opened 8 weeks ago

Closed 6 weeks ago

#9677 enhancement closed fixed (fixed)

Remove obsolete version check from trial.runner

Reported by: mark williams Owned by: Tom Most
Priority: normal Milestone:
Component: trial Keywords:
Cc: Branch:
Author:

Description

Trial can run doctests. Unfortunately, doctests.DocTestCase interacts badly with trial's --until-failure: its tearDown method clears out the dictionary that stores the globals used to exec the code under test, so doctests run twice in one test run will fail. See #2713 and https://bugs.python.org/issue2604.

Twisted has a work around that checks for > Python 2.4. We no longer support that version, and the bug is still present in 3.8, so the check can be removed.

Change History (3)

comment:1 Changed 6 weeks ago by Tom Most

Owner: set to Tom Most
Status: newassigned

comment:2 Changed 6 weeks ago by Tom Most

Keywords: review removed

Approved: https://github.com/twisted/twisted/pull/1165#pullrequestreview-270447965

Currently waiting on tests. I will merge if they don't flake out.

comment:3 Changed 6 weeks ago by Tom Most <twm@…>

Resolution: fixed
Status: assignedclosed

In e50032c:

Merge pull request #1165 from alex/patch-1

Author: alex, markrwilliams
Reviewer: twm
Fixes: ticket:9677

Removed a dead conditional

Note: See TracTickets for help on using tickets.