Opened 22 months ago

Last modified 15 months ago

#9660 defect new

Python 3 Port in twisted\internet\_glibbase

Reported by: doadin Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch:
Author:

Description (last modified by doadin)

Hello so, calling simulate() results in this error in python 3: 

  File "C:\Python\Python37\lib\site-packages\twisted\internet\_glibbase.py", line 385, in simulate
    timeout = min(self.timeout(), 0.01)
TypeError: '<' not supported between instances of 'float' and 'NoneType'

suggestion: ​https://github.com/twisted/twisted/pull/1159

Change History (7)

comment:1 Changed 17 months ago by doadin

Owner: set to hawkowl

comment:2 Changed 16 months ago by doadin

Keywords: review added
Owner: changed from hawkowl to doadin

comment:3 Changed 16 months ago by doadin

Owner: doadin deleted

comment:4 Changed 16 months ago by doadin

Description: modified (diff)

comment:5 Changed 16 months ago by doadin

Description: modified (diff)

comment:6 Changed 15 months ago by Tom Most

Keywords: review removed

I reviewed here: ​https://github.com/twisted/twisted/pull/1159#pullrequestreview-339675040

comment:7 in reply to:  6 Changed 15 months ago by doadin

Replying to Tom Most:

I reviewed here: ​https://github.com/twisted/twisted/pull/1159#pullrequestreview-339675040

Sorry im going to have to admit defeat on this one.

Note: See TracTickets for help on using tickets.