Changes between and of Initial VersionVersion 1Ticket #9544, comment 2


Ignore:
Timestamp:
10/14/2018 09:51:26 PM (9 months ago)
Author:
Tom Most
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #9544, comment 2

    initial v1  
    11I posted a review on GitHub: https://github.com/twisted/twisted/pull/1074#pullrequestreview-164541672  +1
    22
    3 If the None comparison change merited all the overhead of its own ticket/newsfile/review then I'd ask for that, but I think it is fine to make such a trivial stylistic change when working on adjacent code. The tests still pass, after all.
     3If the None comparison change merited all the overhead of its own ticket/newsfile/review then I'd ask for that, but I think it is fine to make such a trivial stylistic change when working on adjacent code. The tests still pass, after all. This is in line with our general approach of "fix linting issues where you find them, and add tests where there were none."
    44
    55Thanks for contributing to Twisted!