Opened 4 months ago

Closed 3 months ago

#9382 defect closed fixed (fixed)

twisted.trial._dist.test.test_disttrial leaks file descriptors

Reported by: mark williams Owned by: Craig Rodrigues <rodrigc@…>
Priority: normal Milestone: Eliminate ResourceWarnings
Component: trial Keywords:
Cc: Branch:
Author:

Description

These tests leave log files open because they don't always call LocalWorker.connectionLost. The resulting ResourceWarnings cause tests that make assertions about generated warnings to fail, such as twisted.trial.test.test_assertions.CallDeprecatedTests.test_nestedDeprecation.

These tests should instead close their files.

Change History (4)

comment:1 Changed 4 months ago by mark williams

Milestone: Eliminate ResourceWarnings

comment:2 Changed 4 months ago by mark williams

Keywords: review added

https://github.com/twisted/twisted/pull/964

This actually fixes everything in twisted.trial._dist.test.

comment:3 Changed 4 months ago by Craig Rodrigues

Keywords: review removed

comment:4 Changed 3 months ago by Craig Rodrigues <rodrigc@…>

Owner: set to Craig Rodrigues <rodrigc@…>
Resolution: fixed
Status: newclosed

In 6570f96:

Merge pull request #964 from twisted/9382-fix-disttrial-leaks

Author: markrwilliams
Reviewer: rodrigc
Fixes: ticket:9382

Fix disttrial leaks

Note: See TracTickets for help on using tickets.