Opened 12 months ago

Closed 9 months ago

#9362 defect closed fixed (fixed)

Remove "terrible hack" in t.c.ssh.filetransfer.FileTransferClient

Reported by: Wim Lewis Owned by: Wim Lewis
Priority: lowest Milestone:
Component: conch Keywords:
Cc: Wim Lewis Branch:


The wasAFile dict in the FileTransferClient class is commented as a "TERRIBLE HACK". It's used to store some information about an outstanding request. It would be cleaner and tidier to store that information as args to the callback function.

Change History (5)

comment:1 Changed 12 months ago by Wim Lewis

Cc: Wim Lewis added
Keywords: review added

comment:2 Changed 9 months ago by Adi Roiban

Keywords: review removed
Owner: set to Wim Lewis

comment:3 Changed 9 months ago by Wim Lewis

Per Adi's comment on the Github PR, removing the wasAFile attribute needs to be announced and okayed on the mailing list.

comment:5 Changed 9 months ago by Adi Roiban <adi.roiban@…>

Resolution: fixed
Status: newclosed

In 0013100:

Merge pull request #949 from wiml/9362-remove-wasAFile

Author: wiml
Reviewer: adiroiban
Fixes: ticket:9362

Remove “terrible hack” in t.c.ssh.filetransfer.FileTransferClient

Note: See TracTickets for help on using tickets.