Opened 9 months ago

Closed 2 months ago

#9287 enhancement closed fixed (fixed)

Add cwd parameter to twisted.runner.procmon.ProcessMonitor.add

Reported by: Moshe Zadka Owned by:
Priority: normal Milestone:
Component: runner Keywords:
Cc: Branch:
Author:

Description

It is sometimes useful to start a process with a different working directory.

Change History (8)

comment:1 Changed 9 months ago by Moshe Zadka

Owner: set to Moshe Zadka

comment:2 Changed 9 months ago by Moshe Zadka

Current plan:

  • Change the thing in procmon.ProcessMonitor.processes to be a custom abc.Sequence class, which pretends to be sized the same as the old tuple, but with a property .cwd
  • The actual access will be by property
  • All sequence methods will be Deprecated

comment:3 Changed 9 months ago by Moshe Zadka

Keywords: review added
Owner: Moshe Zadka deleted

comment:5 Changed 7 months ago by Adi Roiban

Keywords: review removed
Owner: set to Moshe Zadka

See my initial comments from https://github.com/twisted/twisted/pull/896#pullrequestreview-79044459

It looks good but it need a bit more work :)

Thanks!

comment:6 Changed 5 months ago by Moshe Zadka

Keywords: review added
Owner: Moshe Zadka deleted

Addressed all comments. Please re-review

comment:7 Changed 3 months ago by mark williams

Keywords: review removed
Last edited 3 months ago by mark williams (previous) (diff)

comment:8 Changed 2 months ago by Moshe Zadka

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.