Opened 15 months ago

Last modified 3 months ago

#9100 defect new

pop3 server can't handle passwords with spaces

Reported by: bra-fsn Owned by:
Priority: normal Milestone:
Component: mail Keywords: pop3
Cc: Branch:
Author:

Description

If the user provides for example this password: "Sir Lancelot", the following exception is raised:

[POP3,2975,10.6.145.222]           return self.
processCommand(*line.split(' '))
[POP3,2975,10.6.145.222]         File "/usr/local/pypy-5.6/site-packages/twisted/mail/pop3.py", line 594, in processCommand
[POP3,2975,10.6.145.222]           return f(*args)
[POP3,2975,10.6.145.222]       exceptions.TypeError: do_PASS() takes exactly 2 arguments (3 given)

Change History (10)

comment:1 Changed 14 months ago by Evilham

Keywords: review added

Picked this as an easy first contribution. Please review and be kind .

https://github.com/twisted/twisted/pull/769

comment:2 Changed 14 months ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to bra-fsn

comment:3 Changed 14 months ago by Evilham

Keywords: review added

comment:4 Changed 14 months ago by Evilham

Owner: bra-fsn deleted

comment:5 Changed 13 months ago by Glyph

Owner: set to Evilham

Review over at https://github.com/twisted/twisted/pull/769#issuecomment-306682432 - thanks for your contribution and sorry for the delay!

comment:6 Changed 13 months ago by Glyph

Keywords: review removed

comment:7 Changed 13 months ago by Evilham

Keywords: review added
Owner: Evilham deleted

comment:8 Changed 12 months ago by Glyph

Keywords: review removed

Oops, thanks to Mark Williams for reminding me…

comment:9 Changed 12 months ago by Evilham

Keywords: review added

comment:10 Changed 3 months ago by mark williams

Keywords: review removed

The PR for this is closed: https://github.com/twisted/twisted/pull/769#event-1297279570

I don't see a replacement, so I'm taking this out of review.

Note: See TracTickets for help on using tickets.