Opened 5 years ago

Closed 5 years ago

#8981 enhancement closed fixed (fixed)

Explicit Request interface for HTTPChannel

Reported by: mark williams Owned by: mark williams
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: 8981-explicit-request-httpchannel-interface
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description

twisted.web.http.HTTPChannel expects an implicit interface out of twisted.web.http.Request. It will need to interact with a different one (that, for example, communicates the method, URI and version to the request before the entire body's been received) for Twisted to support streaming requests and #288 to get fixed.

Before we can implement the new one, we should define the old one and make twisted.web.http.Request implement it. Then HTTPChannel can look at what interface is provided to determine whether to support streaming or not.

The new interface should be private so that users don't attempt to implement it, and should make it clear that it's deprecated. The future will be all streaming!

Change History (6)

comment:1 Changed 5 years ago by mark williams

Keywords: review added

comment:2 Changed 5 years ago by Jean-Paul Calderone

Owner: set to Jean-Paul Calderone
Status: newassigned

comment:3 Changed 5 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Jean-Paul Calderone to mark williams
Status: assignednew

comment:4 Changed 5 years ago by Jean-Paul Calderone

Branch: 8981-explicit-request-httpchannel-interface

comment:5 Changed 5 years ago by Mark Williams <mrw@…>

In e8e8e8a:

Error: Processor CommitTicketReference failed
 does not appear to be a Git repository. See the log for more information.

comment:6 Changed 5 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.