Opened 5 years ago

Closed 5 years ago

#8973 defect closed fixed (fixed)

handshakeCompleted never called when SSL4ClientEndpoint used.

Reported by: mark williams Owned by: mark williams
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch:
Author:

Description

A protocol that implements IHandshakeListener never has its handshakeCompleted method called when connected via SSL4ClientEndpoint. That's because twisted.internet.endpoints._WrappingProtocol doesn't forward IHandshakeListener. It should!

Change History (3)

comment:1 Changed 5 years ago by mark williams

Keywords: review added

comment:2 Changed 5 years ago by Chris Wolfe

Keywords: review removed
Owner: set to mark williams

Thanks for working on this! This looks ready to land, so please feel free to merge at your convenience (or seek another review if you feel like I may have missed a specific question/issue). The review is available at https://github.com/twisted/twisted/pull/656#pullrequestreview-15144502)

comment:3 Changed 5 years ago by Mark Williams <markrwilliams@…>

Resolution: fixed
Status: newclosed

In 4ca2dbd:

Error: Processor CommitTicketReference failed
 does not appear to be a Git repository. See the log for more information.
Note: See TracTickets for help on using tickets.