Opened 18 months ago

Last modified 3 months ago

#8966 enhancement new

Adding curve25519 and ed25519

Reported by: the0id Owned by: the0id
Priority: normal Milestone:
Component: conch Keywords:
Cc: Branch:
Author: the0id

Description (last modified by the0id)

This adds curve25519 to Twisted. Cryptography doesn't support 25519, so pyNaCl is required.

PR: #644

Change History (8)

comment:1 Changed 18 months ago by the0id

Keywords: review added

The unit tests aren't done (surprise!), but I'm flagging this for review because I want to see if there are any changes needed before this would be accepted. Then write tests for the end result.

comment:2 Changed 18 months ago by the0id

Owner: set to the0id
Status: newassigned

comment:3 Changed 18 months ago by the0id

Description: modified (diff)

comment:4 Changed 18 months ago by the0id

Status: assignednew

comment:5 Changed 17 months ago by the0id

The unit tests are done (surprise!).

comment:6 Changed 17 months ago by Glyph

Keywords: review removed

Thanks for continuing on the path to give conch cipher-parity with OpenSSH :). I added a review on Github here: https://github.com/twisted/twisted/pull/644#pullrequestreview-18959050

comment:7 Changed 17 months ago by the0id

Keywords: review added

Glad to. :)

I've made a change and have addressed the other comments.

I also wanted to reference ticket 9014 that I've opened and marked for review since it directly affects this ticket.

Note: See TracTickets for help on using tickets.