Opened 5 years ago

Closed 5 years ago

#8761 enhancement closed fixed (fixed)

dist3 should be a blacklist, not a whitelist

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: 8761-dist3-blist
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description

We're at the point where we ought to make it a blacklist.

Change History (11)

comment:1 Changed 5 years ago by hawkowl

Branch: 8761-dist3-blist

comment:2 Changed 5 years ago by hawkowl

Keywords: review added

https://github.com/twisted/twisted/pull/501

Please review. Will need to compat policy except before merge, which I will put on the ML.

comment:3 Changed 5 years ago by Glyph

Keywords: review removed
Owner: set to hawkowl

Thanks for fixing this, hawkowl.

This will make it easier for people to add new code without mistakenly forgetting to add it to dist3.

modulo compat policy and passing builds this looks mostly OK. I put a few comments regarding the docstring on the github issue; please address those. Love the diffstat: +230-770!

comment:4 Changed 5 years ago by Adi Roiban

Happy to see the blacklist :)

Can we have _dist3.py renamed to something like _not_python3_ported.py or something else? I find the _dist3.py very generic.

Also, I think that in this branch we should update the current documention / wiki in which twisted.python.dist3 is mentioned... here are some places https://github.com/twisted/twisted/pull/467/commits/0008cf1b123bd9e0a99293d622751486de676e43

Thanks!

comment:5 Changed 5 years ago by Adi Roiban

and with the rename of dist3.py we should get in contact with the maintainer of the Twisted py3 port graph website. Not sure if the maintainer is on the ML.

comment:6 Changed 5 years ago by hawkowl

Keywords: review added
Owner: hawkowl deleted

I updated the documentation, and detailed the policy that this blacklist implies.

comment:7 Changed 5 years ago by Glyph

Keywords: review removed
Owner: set to hawkowl

Doc changes look good. Although all the cleanups could have been a different branch :).

Again, this is good to land as soon as we're through the compat process.

comment:8 Changed 5 years ago by Glyph

adiroiban - since the py3 port website is an aid to twisted developers, it's fine to break compat with it ;). The author is on the ML (although I believe they have other priorities at the moment).

comment:10 Changed 5 years ago by hawkowl

Will merge on thurs (when the compat exception clears)

comment:11 Changed 5 years ago by Amber Brown <hawkowl@…>

Resolution: fixed
Status: newclosed

In b920626:

Error: Processor CommitTicketReference failed
 does not appear to be a Git repository. See the log for more information.
Note: See TracTickets for help on using tickets.