Opened 5 years ago

Closed 5 years ago

#8758 enhancement closed fixed (fixed)

twisted.test.test_iutils fails on Windows with Python 3.5

Reported by: Craig Rodrigues Owned by: Craig Rodrigues <rodrigc@…>
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: 8758-rodrigc-iutils-py3
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description

When running twisted.test.test_iutils on Windows with Python 3.5, it fails: 

===============================================================================
[FAIL]
Traceback (most recent call last):
  File "C:\Users\Craig\twisted3\twisted\trial\_synctest.py", line 425, in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
  File "C:\Python35\Lib\unittest\case.py", line 820, in assertEqual
    assertion_func(first, second, msg=msg)
  File "C:\Python35\Lib\unittest\case.py", line 813, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: b'hello world\r\n' != b'hello world\n'

twisted.test.test_iutils.ProcessUtilsTests.test_output
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "C:\Users\Craig\twisted3\twisted\test\test_iutils.py", line 123, in gotOutputAndValue
    self.assertEqual(out, b"hello world!\n")
  File "C:\Users\Craig\twisted3\twisted\trial\_synctest.py", line 425, in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
  File "C:\Python35\Lib\unittest\case.py", line 820, in assertEqual
    assertion_func(first, second, msg=msg)
  File "C:\Python35\Lib\unittest\case.py", line 813, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: b'hello world!\r\n' != b'hello world!\n'

twisted.test.test_iutils.ProcessUtilsTests.test_outputAndValue
-------------------------------------------------------------------------------

Change History (3)

comment:1 Changed 5 years ago by Craig Rodrigues

Branch: → 8758-rodrigc-iutils-py3
Keywords: review added

​https://github.com/twisted/twisted/pull/497

comment:2 Changed 5 years ago by Abhishek Choudhary

Keywords: review removed

changes look good. Please merge

comment:3 Changed 5 years ago by Craig Rodrigues <rodrigc@…>

Owner: set to Craig Rodrigues <rodrigc@…>
Resolution: → fixed
Status: new → closed

In b3bf0d2:

Error: Processor CommitTicketReference failed
 does not appear to be a Git repository. See the log for more information.
Note: See TracTickets for help on using tickets.