Opened 3 years ago

Closed 3 years ago

#8527 enhancement closed fixed (fixed)

Replace file() with open() in twisted/internet

Reported by: Craig Rodrigues Owned by: Craig Rodrigues
Priority: normal Milestone: Python-3.x
Component: conch Keywords:
Cc: Branch: 8527-rodrigc-file
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description

In Python 3, file() is gone (see https://docs.python.org/3/whatsnew/3.0.html#builtins ), and needs to be replaced with open() which works on Python 2 and 3

Change History (4)

comment:1 Changed 3 years ago by Craig Rodrigues

Branch: 8527-rodrigc-file
Component: coreconch
Keywords: review added
Summary: Replace file() with open() in twisted/conchReplace file() with open() in twisted/internet

comment:2 Changed 3 years ago by Cory Benfield

Keywords: review removed
Owner: set to Craig Rodrigues

Looks good to me, go ahead and merge when ready.

comment:3 Changed 3 years ago by Craig Rodrigues

Lukasa, I can't merge this one because codecov says there is no coverage.

comment:4 Changed 3 years ago by GitHub <noreply@…>

Resolution: fixed
Status: newclosed

In 177052b:

Merge pull request #253 from twisted/8527-rodrigc-file

Author: rodrigc
Reviewer: Lukasa, alex
Fixes: #8527

Replace file() with open() in twisted/internet

Note: See TracTickets for help on using tickets.