Opened 4 years ago
Closed 4 years ago
#8527 enhancement closed fixed (fixed)
Replace file() with open() in twisted/internet
| Reported by: | Craig Rodrigues | Owned by: | Craig Rodrigues |
|---|---|---|---|
| Priority: | normal | Milestone: | Python-3.x |
| Component: | conch | Keywords: | |
| Cc: | Branch: |
8527-rodrigc-file
branch-diff, diff-cov, branch-cov, buildbot |
|
| Author: |
Description
In Python 3, file() is gone (see https://docs.python.org/3/whatsnew/3.0.html#builtins ), and needs to be replaced with open() which works on Python 2 and 3
Change History (4)
comment:1 Changed 4 years ago by
| Branch: | → 8527-rodrigc-file |
|---|---|
| Component: | core → conch |
| Keywords: | review added |
| Summary: | Replace file() with open() in twisted/conch → Replace file() with open() in twisted/internet |
comment:2 Changed 4 years ago by
| Keywords: | review removed |
|---|---|
| Owner: | set to Craig Rodrigues |
Looks good to me, go ahead and merge when ready.
comment:3 Changed 4 years ago by
Lukasa, I can't merge this one because codecov says there is no coverage.
Note: See
TracTickets for help on using
tickets.
See: https://github.com/twisted/twisted/pull/253