Opened 6 years ago

#8492 enhancement new

twisted.spread.pb.Broken should support keepalive

Reported by: Adi Roiban Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch:
Author:

Description

We have this monkey patching in Twisted's buildbot configuration

# Enable TCP keepalives.  The build master is terrible at noticing
# disconnected slaves.  Also it's terrible at letting me enable tcp
# keepalives.
from twisted.spread.pb import PBServerFactory
_parent = PBServerFactory.protocol
class KeepaliveBroker(_parent):
    def makeConnection(self, transport):
        transport.setTcpKeepAlive(True)
        return _parent.makeConnection(self, transport)
PBServerFactory.protocol = KeepaliveBroker

I think that we should fix this upstream and then in buildbot so that this is not needed

Change History (0)

Note: See TracTickets for help on using tickets.