Opened 4 years ago

Closed 4 years ago

#8479 enhancement closed fixed (fixed)

Update setup.py metadata to advertise Python 3.5

Reported by: Giorgio Salluzzo Owned by: Giorgio Salluzzo
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: 8479-mindflayer-enable-python
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description

With this ticket I'm proposing to effectively add the Python 3.5 support to Twisted, adding the related metadata to enable the installation of it via PIP. I've already added a PR on Github to speed up the process (https://github.com/twisted/twisted/pull/180).

Change History (4)

comment:1 Changed 4 years ago by Adi Roiban

Keywords: review removed
Owner: set to Giorgio Salluzzo

Thanks for your contribution.

I am not an expert in pypi metadata or how setuptools should work.

Can you please update your branch to include a release notes fragment as described here. http://twistedmatrix.com/trac/wiki/ReviewProcess#Newsfiles

The text should be as developer friendly as possible and should help developers what new functionalities are available once we make a new release using your patch...or what problem is now fixed.

It would be great if you could also write an automated tests for that future updated will not introduce a regression.

That text should also help me understand what was broken before and I hope that will help me understand how I can test your fix.

Thanks!

comment:2 Changed 4 years ago by GitHub <noreply@…>

In 355d735:

Create 8479.misc

Adding file documenting my change for ticket #8479.

comment:3 Changed 4 years ago by Adi Roiban

Branch: 8479-mindflayer-enable-python
Summary: Enable Python 3.5 version in setup.py metadataUpdate setup.py metadata to advertise Python 3.5

See PR for more comments.

So in the end this is not about enabling anything, but just about updating the metadata.

Will merge. Thanks!

comment:4 Changed 4 years ago by Adi Roiban <adi.roiban@…>

Resolution: fixed
Status: newclosed

In 54f95a4e:

Merge 8479-mindflayer-enable-python: Update metadata to advertise Python 3.5.

Author: mindflayer
Reviewer: adiroiban
Fixes: #8479

Note: See TracTickets for help on using tickets.