Opened 3 years ago

Closed 3 years ago

#8447 enhancement closed duplicate (duplicate)

Add more tests to

Reported by: Craig Rodrigues Owned by: Craig Rodrigues
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: 8447-rodrigc-moretests
branch-diff, diff-cov, branch-cov, buildbot

Description (last modified by Craig Rodrigues)

As we port more things to Python 3, we can gradually add more tests to, so that more tests get executed on Python 3

Change History (6)

comment:1 Changed 3 years ago by Craig Rodrigues

Description: modified (diff)

comment:2 Changed 3 years ago by Craig Rodrigues

Keywords: review added
Last edited 3 years ago by Craig Rodrigues (previous) (diff)

comment:3 Changed 3 years ago by Craig Rodrigues

Branch: 8447-rodrigc-moretests

comment:4 Changed 3 years ago by Adi Roiban

Keywords: review removed
Owner: set to Craig Rodrigues

Changes look good, but what is the target of this ticket?

I see that it has a .misc topfile? Why?

I would say that all ported modules should be advertise in the release notes...that is, we need separate tickets for unrelated modules..

Please create separate tickets or updated the topfile to advertise all modules which are now ported on Python3.


comment:5 Changed 3 years ago by Craig Rodrigues

I didn't port any modules to Python 3 in this ticket. I just added tests which now seem to work in Python 3. Looks like in previous passes, some tests were forgotten from this file as they were added, such as files.

I will update the topfile, to not be a misc, and list the tests and modules that now seem to work.

comment:6 Changed 3 years ago by Craig Rodrigues

Resolution: duplicate
Status: newclosed

Going to break this up into separate tickets with separate reviews.

Note: See TracTickets for help on using tickets.