Opened 5 years ago

Closed 5 years ago

#8299 defect closed fixed (fixed)

Reactor selection in twisted.application should work on Py3

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: branches/reactor-app-py3-8299
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl


Right now twisted/plugins/ isn't there, and so we don't get --reactor=foo working.

Change History (4)

comment:1 Changed 5 years ago by hawkowl

Author: hawkowl
Branch: branches/reactor-app-py3-8299

(In [47275]) Branching to reactor-app-py3-8299.

comment:2 Changed 5 years ago by hawkowl

Keywords: review added
Type: enhancementdefect

Happy with this, please review.

comment:3 Changed 5 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

can we have something like this

__all__ = ["default", "select", "poll", "epoll", "kqueue"]
if not _PY3:
   __all__.extend(["wx", "gi", "gtk2", "gtk3", "glib2", "glade"])

With the current approach I find it harder to see py2 has all py3 reactor + some more.

For the release notes fragment

twisted.application-using applications (trial, twistd, etc)


Twisted applications (trial, twistd, etc) using twisted.application framework ....

All good.

ubuntu12.04-py2.7-coverage is failing, but I don't think that this is related


comment:4 Changed 5 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [47288]) Merge reactor-app-py3-8299: Port twisted.plugins.twisted_reactors to Python 3

Author: hawkowl Reviewer: adiroiban Fixes: #8299

Note: See TracTickets for help on using tickets.