Opened 6 years ago

Closed 6 years ago

#8269 enhancement closed fixed (fixed)

Twisted's tox file should support specifying the different reactors

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/tox-reactors-8269
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description (last modified by hawkowl)

Right now it's just py27-tests or whatever -- it should be something like py27-tests-epoll and such (using the "platform" key to disable them on platforms), IDEALLY -- but it looks like that due to tox limitations, it'll have to be an environment variable, or we duplicate the trial command with each of the settings, for both -tests and -coverage (which isn't great).

I think the environment variable is the best right now, to make tox usable on the buildbots.

Change History (5)

comment:1 Changed 6 years ago by hawkowl

Description: modified (diff)

comment:2 Changed 6 years ago by hawkowl

Author: hawkowl
Branch: branches/tox-reactors-8269

(In [47133]) Branching to tox-reactors-8269.

comment:3 Changed 6 years ago by hawkowl

Keywords: review added

This adds it as a environment variable -- TWISTED_REACTOR in the environment is given to the --reactor trial flag.

Builders spun, please review.

comment:4 Changed 6 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

I think that if you are happy with this, we should merge it.

Are the developers supposed to run the same tox file and set the TWISTED_REACTOR env var to run some tests? If yes, is this documented?

... even if this is not documented, I hope that this is just a transition phase and in the end we will have all logic for building and running tests encapsulated in the repo.

right now, the other part of this change is in twisted-infra/braid ...and there it can be merged without review... so I would say that since this is devtools part of twisted, we should also merge it without review.

thanks!

comment:5 Changed 6 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [47181]) Merge tox-reactors-8269: Add the ability to test specific reactors using the tox config

Author: hawkowl Reviewer: adiroiban Fixes: #8269

Note: See TracTickets for help on using tickets.