Can not import twisted.trial.reporter without first importing unittest (or some other class)

[alex----]

Looks like importing reporter imports unittest, which imports _asyncrunner which import reporter which is not going to be possible while trying to import reporter.

You can work around the issue by importing unittest first (which imports _asyncrunner which imports reporter.

This was not the case in earlier versions of twisted. I am seeing it in version 16.0.0 of twisted.

>>> from twisted.trial import reporter
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/twisted/trial/reporter.py", line 29, in <module>
    from twisted.trial.unittest import makeTodo
  File "/usr/local/lib/python2.7/dist-packages/twisted/trial/unittest.py", line 16, in <module>
    from twisted.trial._asyncrunner import (
  File "/usr/local/lib/python2.7/dist-packages/twisted/trial/_asyncrunner.py", line 16, in <module>
    from twisted.trial import itrial, reporter
ImportError: cannot import name reporter
>>> from twisted.trial import unittest
>>> from twisted.trial import reporter
>>>

[Thijs Triemstra]

fixing markup

[Julian Berman]

#8759 was closed as a duplicate of this ticket.

[Colin Watson]

​https://github.com/twisted/twisted/pull/1148

[Tom Most]

Reviewed: ​https://github.com/twisted/twisted/pull/1148#pullrequestreview-261527868

I will wait for a few days for further feedback on #twisted-dev in case anyone objects to merging without tests. In the meantime I'll keep this assigned to me.

[Tom Most]

Merged in ​https://github.com/twisted/twisted/commit/a4c171b461533f04fa7c041746e9a708604254e5