Opened 4 years ago

Closed 4 years ago

#8064 enhancement closed fixed (fixed)

Port twisted.test.iosim to Python 3

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: branches/iosim-py3-8064
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description

This is a requirement for Treq to be ported.

Change History (4)

comment:1 Changed 4 years ago by hawkowl

Author: hawkowl
Branch: branches/iosim-py3-8064

(In [45967]) Branching to iosim-py3-8064.

comment:2 Changed 4 years ago by hawkowl

Keywords: review added

This was mostly ported, but some things weren't bytes/unicode clean.

Fixed a few things, added a test to test it. Builders spun, please review.

comment:3 Changed 4 years ago by Glyph

Keywords: review removed
Owner: set to hawkowl

The ticket description should have been more specific, though: it was already "ported" in that it was distributed and its tests were running; this was to fix a specific issue with writeSequence, implements, and clean up some random twistedchecker errors.

Nevertheless, LGTM, it's all minor improvements and not too big to review; please land.

comment:4 Changed 4 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [45998]) Merge iosim-py3-8064: Port the rest of twisted.test.iosim to Python 3

Author: hawkowl Reviewer: glyph Fixes: #8064

Note: See TracTickets for help on using tickets.