Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#7992 enhancement closed fixed (fixed)

Stop relying on SSLv23_METHOD having SSLv3 in it

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/sslv23method-7992
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description

[FAIL]
Traceback (most recent call last):
  File "/buildslave/fedora22-py2.7/Twisted/twisted/test/test_sslverify.py", line 1239, in test_SSLv23
    method=SSL.SSLv23_METHOD)))
  File "/buildslave/fedora22-py2.7/Twisted/twisted/trial/_synctest.py", line 437, in assertEqual
    super(_Assertions, self).assertEqual(first, second, msg)
  File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib64/python2.7/unittest/case.py", line 836, in assertSetEqual
    self.fail(self._formatMessage(msg, standardMsg))
twisted.trial.unittest.FailTest: Items in the first set but not the second:
<ProtocolVersion=SSLv3>

twisted.test.test_sslverify.ProtocolVersionTests.test_SSLv23

Change History (5)

comment:1 Changed 4 years ago by hawkowl

Author: hawkowl
Branch: branches/sslv23method-7992

(In [45417]) Branching to sslv23method-7992.

comment:2 Changed 4 years ago by hawkowl

Keywords: review added

Removed the test, since it's worthless.

https://buildbot.twistedmatrix.com/boxes-unsupported?branch=/branches/sslv23method-7992 shows green F22, the rest of the builders are green, please review.

comment:3 Changed 4 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

Looks good. I am ok with removing the tests as it looks like a test for the content of the SSL.SSLv23_METHOD constant.

Don't forget to add the news file... then merge :)

Thanks!

comment:4 Changed 4 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [45420]) Merge sslv23method-7992: Remove useless test that checks the contents of the SSLv23_METHOD constant

Author: hawkowl Reviewer: adiroiban Fixes: #7992

comment:5 Changed 4 years ago by hawkowl

Milestone: Twisted 15.4

Ticket retargeted after milestone deleted

Note: See TracTickets for help on using tickets.