Opened 4 years ago

Closed 4 years ago

#7987 enhancement closed fixed (fixed)

twisted.positioning should be ported to Python 3

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: branches/positioning-py3-7987
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl


Change History (4)

comment:1 Changed 4 years ago by hawkowl

Author: hawkowl
Branch: branches/positioning-py3-7987

(In [45395]) Branching to positioning-py3-7987.

comment:2 Changed 4 years ago by hawkowl

Keywords: review added

Tests look green. Coverage looks good. I think I've made everything bytes that should be in the docs. One spurious pyflakes error (it's not a failure on Py3-ran Pyflakes).

Please review.

comment:3 Changed 4 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

Thanks for working on this.

  • Why not make FancyEqMixin inherit directly from object ?
  • Please try to fix the pyflake error. You can use twistd.python.reflect.namedModule to avoid the pyflake errors. I know that this is a bit of extra work but I would like to have pyflakes errors clean and not get back to the mess we have with twistedchecker reported errors.

Please address my commends and merge.


comment:4 Changed 4 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [45437]) Merge positioning-py3-7987: Port twisted.positioning to Python 3

Author: hawkowl Reviewer: adiroiban Fixes: #7987

Note: See TracTickets for help on using tickets.