Opened 3 years ago

Closed 3 years ago

#7964 enhancement closed fixed (fixed)

Remove support for subproject packaging

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/remove-subproject-packagaing-7964-2
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description

This will remove:

  • Subproject packaging
  • Subproject versions

This will leave the existing newsfile regime.

Change History (7)

comment:1 Changed 3 years ago by hawkowl

Author: hawkowl
Branch: branches/remove-subproject-packagaing-7964

(In [45200]) Branching to remove-subproject-packagaing-7964.

comment:2 Changed 3 years ago by hawkowl

Branch: branches/remove-subproject-packagaing-7964branches/remove-subproject-packagaing-7964-2

(In [45204]) Branching to remove-subproject-packagaing-7964-2.

comment:3 Changed 3 years ago by hawkowl

Keywords: review added

Builders spun, please review.

comment:4 Changed 3 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

Changes look good but I dont know what to check.

Do we have tests for the new updateREADME ?

I see that test_changeAllProjectVersionsPreRelease still has Twisted Core and Twisted Web.

The review request has no notes about how I can do manual tests for the changes... I tried to find some info in https://twistedmatrix.com/trac/wiki/ReleaseProcess .... ./bin/admin/change-versions and ./bin/admin/build-news ./bin/admin/build-tarballs are extremly slow

I suppose that build-news is not ready yet ... but the other command should be.

I see that the change-versions command still creates files for subprojects. Is that ok?

build-tarballs creates a single file ... so does python setup.py sdist

Please check my commend and resubmit for review.

Many thanks!

comment:5 Changed 3 years ago by hawkowl

Keywords: review added
Owner: hawkowl deleted

Hi Adi,

The updateREADME is covered by the other tests. (changeAllProjectVersions)

The newsfile regime is still in place (that is, there's subprojects with NEWS files, but they do not have independent setup.pys and versions). So having Twisted Core and Twisted Web is correct.

The changes are fully covered by the unit tests, but running those commands should test it all. I have tested it manually, locally, and it works as expected (updating READMEs, but no _version.pys, and only making one tarball). change-versions, build-news, and build-tarballs all work.

My plan is that there will be a follow-up to replace build-tarballs with python setup.py sdist. This ticket makes that a lot simpler (meaning that subprojects aren't packaged separately).

Thanks for the review.

comment:6 Changed 3 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

Great. Ready to merge. Thanks!

comment:7 Changed 3 years ago by hawkowl

Resolution: fixed
Status: newclosed

Fixed. The commit thing didn't trigger, though.

Note: See TracTickets for help on using tickets.