Opened 5 years ago

Closed 3 years ago

#7947 enhancement closed fixed (fixed)

DeprecationWarning at module level

Reported by: max.vdb Owned by:
Priority: normal Milestone:
Component: core Keywords: deprecation interfaces twisted
Cc: Branch: trunk
branch-diff, diff-cov, branch-cov, buildbot
Author: max.vdb

Description

Hi,

I've been trying to remove a DeprecationWarning from my codebase, and it looks like it's directly fired at module level in twisted.internet.interfaces. Here is the code: https://github.com/twisted/twisted/blob/twisted-15.2.1/twisted/internet/interfaces.py#L2631-L2636

I think it should be nested under the previous method in the file, as opposed to at module level.

Am I right?

Thanks,

Max

Change History (1)

comment:1 Changed 3 years ago by Craig Rodrigues

Resolution: fixed
Status: newclosed

You are right. The deprecation at https://github.com/twisted/twisted/blob/twisted-15.2.1/twisted/internet/interfaces.py#L2631-L2636, should have been done at the class level for IStreamClientEndpointStringParser, not the module level.

However, IStreamClientEndpointStringParser and the deprecation was removed in 8094

Note: See TracTickets for help on using tickets.