Opened 6 years ago
Closed 6 years ago
#7892 task closed fixed (fixed)
Remove Lore
Reported by: | hawkowl | Owned by: | hawkowl |
---|---|---|---|
Priority: | low | Milestone: | Lore to Sphinx |
Component: | lore | Keywords: | |
Cc: | Branch: |
branches/remove-lore-7892
branch-diff, diff-cov, branch-cov, buildbot |
|
Author: | hawkowl |
Description
Eventually, we should remove Lore completely.
Change History (10)
comment:1 Changed 6 years ago by
Author: | → hawkowl |
---|---|
Branch: | → branches/remove-lore-7892 |
comment:2 Changed 6 years ago by
Keywords: | review added |
---|
So, in making sure that nothing that anything else uses was inadvertently deprecated, I decided to just do the patch while I didn't have the willpower to hack through anything else.
This probably shouldn't land yet. Maybe in 15.3 or 15.4.
comment:3 Changed 6 years ago by
Changes look good.
From http://twistedmatrix.com/trac/wiki/CompatibilityPolicy
At the earliest, release R+2 and one year after release R, but often much later:
Lore was deprecated in 14.0.0 (2014-05-08) ... so we are one year after
We had 15.0 15.1 so we should be past R+2
I think that it can land now ... well in 15.3 as 15.2 is already pre-released.
Thanks!
comment:4 Changed 6 years ago by
Keywords: | review removed |
---|---|
Owner: | set to hawkowl |
Hi HawkOwl,
Thanks for working on this.
Test failure looks to be the random threading test bug that glyph was cleaning up. Other than that, seems green on the bots.
The following files still refer to lore (and are not of historic variety or mention its deprecation/removal):
twisted/python/zsh/_lore (should probably be removed) docs/core/howto/book.tex -- \newcommand{\loreref}[1]{% (is book.tex still used by anything non-lore? if not, we can kill it.
if it is, this command needs a better name)
docs/core/howto/glossary.rst -- remove lore from glossary? docs/core/development/policy/svn-dev.rst -- we should probably update the "build-doc" to mention sphinx admin/update-documentation.py -- If this script is still in use, it should blame sphinx and not lore. If not, kill it with fire plz.
The zsh one should definitely be killed as part of this diff. The other ones, I guess, are more of a judgement call whether they have to be done here, but I would certainly prefer it.
If you kill only the zsh file, feel free to merge. Otherwise, please resubmit.
comment:5 Changed 6 years ago by
Keywords: | review added |
---|---|
Owner: | hawkowl deleted |
Thanks for the review, moshez.
- The zsh one will be covered in #7898.
- Removed.
- Removed.
- Updated to use the proper builder.
- Killed with fire :D
Builders spun, looking good, please review.
comment:6 Changed 6 years ago by
Keywords: | review removed |
---|---|
Owner: | set to hawkowl |
Hi HawkOwl,
Thanks for working on this. Looks good to me -- go ahead and merge!
[Goodbye, lore!]
comment:7 Changed 6 years ago by
Summary: | (Eventually) Remove Lore → Remove Lore |
---|
comment:8 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:9 Changed 6 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:10 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [44759]) Branching to remove-lore-7892.