Opened 7 years ago

Closed 7 years ago

#7875 defect closed fixed (fixed)

Typo in narrative docs for twisted.logger

Reported by: Chris Wolfe Owned by: Chris Wolfe
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/logger-docs-typo-7875
branch-diff, diff-cov, branch-cov, buildbot
Author: adiroiban

Description

The narrative documentation for twisted.logger has a typo.

Instead of

As such, it defaults to logging that the :api:twisted.logger.LogLevel.critical <critical> level.

the line should read:

As such, it defaults to logging at the :api:twisted.logger.LogLevel.critical <critical> level.

Attachments (2)

typo-logger-howto-docs-7875-1.diff (921 bytes) - added by Chris Wolfe 7 years ago.
patch, newsfile
typo-logger-howto-docs-7875-2.diff (919 bytes) - added by Chris Wolfe 7 years ago.
fix ending on newsfile

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Chris Wolfe

Owner: set to Chris Wolfe

Changed 7 years ago by Chris Wolfe

patch, newsfile

Changed 7 years ago by Chris Wolfe

fix ending on newsfile

comment:2 Changed 7 years ago by Chris Wolfe

Keywords: review added
Owner: Chris Wolfe deleted

The patch https://twistedmatrix.com/trac/attachment/ticket/7875/typo-logger-howto-docs-7875-2.diff fixes the typo and adds an empty topfile. I left the topfile empty since the patch is a two character change.

Thanks!

comment:3 Changed 7 years ago by Adi Roiban

Author: adiroiban
Branch: branches/logger-docs-typo-7875

(In [44612]) Branching to logger-docs-typo-7875.

comment:4 Changed 7 years ago by Adi Roiban

Keywords: review removed
Owner: set to Chris Wolfe

changes looks good. thanks.... waiting for build to end before merging.

comment:5 Changed 7 years ago by Adi Roiban

Resolution: fixed
Status: newclosed

(In [44614]) Merge logger-docs-typo-7875: Fix typo in narrative docs for twisted.logger.

Author: herrwolfe Reviewer: adiroiban Fixes: #7875

Note: See TracTickets for help on using tickets.