Opened 7 years ago

Closed 7 years ago

#7815 enhancement closed fixed (fixed)

twisted.trial.reporter's deprecated methods should be removed

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone:
Component: trial Keywords:
Cc: Jonathan Lange Branch: branches/testresult-removedeprecated-7815
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description

It's been deprecated since 2008, so the Py3 porting time sounds like a good time to do it.

Change History (6)

comment:1 Changed 7 years ago by DefaultCC Plugin

Cc: Jonathan Lange added

comment:2 Changed 7 years ago by hawkowl

Author: hawkowl
Branch: branches/testresult-removedeprecated-7815

(In [44055]) Branching to testresult-removedeprecated-7815.

comment:3 Changed 7 years ago by hawkowl

Summary: twisted.trial.reporter.TestResult's deprecated methods should be removedtwisted.trial.reporter's deprecated methods should be removed

comment:4 Changed 7 years ago by hawkowl

Keywords: review added

Builders spun, plz reviewz :)

comment:5 Changed 7 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

not all builders are green ... pyflakes and twistechecker.

btw. you can not run pyflakes locally on the files that you have changed as the Twisted code is much cleaner of old pyflakes errors

---

Changes looks good. Please clean the code and merge.

Thanks!

comment:6 Changed 7 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [44168]) Merge testresult-removedeprecated-7815: twisted.trial.reporter's deprecated methods should be removed

Author: hawkowl Reviewer: adiroiban Fixes: #7815

Note: See TracTickets for help on using tickets.