Opened 3 years ago

Closed 3 years ago

#7684 defect closed fixed (fixed)

twisted.internet.endpoints._parseSSL defaults to SSLv23_METHOD, should default to None

Reported by: Glyph Owned by: Glyph
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/ssl-version-default-7684
branch-diff, diff-cov, branch-cov, buildbot
Author: glyph

Description

If you specify SSLv23_METHOD, CertificateOptions only defaults to disabling SSLv2. However, if you specify None, i.e. what CertificateOptions deems to be the default, it will disable SSLv3.

Attachments (1)

t7684.diff (2.0 KB) - added by Alex Gaynor 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by Alex Gaynor

Attachment: t7684.diff added

comment:1 Changed 3 years ago by Alex Gaynor

Keywords: review added
Owner: changed from Alex Gaynor to Glyph

comment:2 Changed 3 years ago by Glyph

Author: glyph
Branch: branches/ssl-version-default-7684

(In [43391]) Branching to ssl-version-default-7684.

comment:3 Changed 3 years ago by Glyph

Keywords: review removed

Looks like the buildbot is happy. The change looks good. I am going to apply exarkun's suggested NEWS file change and land.

comment:4 Changed 3 years ago by Glyph

Resolution: fixed
Status: newclosed

(In [43395]) Merge ssl-version-default-7684: Disable SSLv3 by default for string server endpoints.

Author: Alex

Reviewer: glyph

Fixes: #7684

...

Note: See TracTickets for help on using tickets.