Opened 5 years ago

Closed 3 years ago

#7598 enhancement closed fixed (fixed)

Port twisted.spread.pb to Python3

Reported by: Wolfgang Rohdewald Owned by: Glyph
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: port-pb-7598
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description

This includes not yet ported lower level modules. Found so far:

banana styles

Change History (5)

comment:1 Changed 3 years ago by hawkowl

Branch: port-pb-7598
Keywords: py3k removed

comment:2 Changed 3 years ago by Glyph

Opening up a PR to start seeing CI results presented: https://github.com/twisted/twisted/pull/436

comment:3 Changed 3 years ago by Glyph

Keywords: review added
Owner: Wolfgang Rohdewald deleted

The branch there ports PB to Python 3. There might still be a few coverage issues, and since I trust codecov, I'm not entiirely sure. But this is definitely worth at least a first pass review at this point.

It also significantly refactors a lot of code duplication especially in the area of deserialization; previously there were about six different things that needed to "make a new object" and would do them in various subtly broken ways. In this port branch it is now narrowed down to one, along with some other benefits (the weird lifecycle-management hack that Cacheable uses is now visibly _part_ of RemoteCache rather than just floating around inside jelly).

I tried to keep it as minimal as possible but it's still about 2x as big as I've been looking to make patches these days. If it's really tough for a reviewer to get their head around this I could probably do, say, just the Jelly changes first, but hopefully it's comprehensible enough that we won't need to resort to breaking it up.

comment:4 Changed 3 years ago by Craig Rodrigues

Keywords: review removed
Owner: set to Glyph

comment:5 Changed 3 years ago by Glyph <glyph@…>

Resolution: fixed
Status: newclosed

In 7133de6:

Merge pull request #436 from twisted/port-pb-7598

Author: hawkowl, glyph

Reviewer: rodrigc

Fixes: #7598

Port Perspective Broker to Python 3.

Note: See TracTickets for help on using tickets.