Opened 16 years ago

Closed 12 years ago

#754 enhancement closed fixed (fixed)

examples not using reactor.run() should point to twistd

Reported by: dpollet Owned by:
Priority: low Milestone:
Component: core Keywords: documentation
Cc: spiv, dpollet, Thijs Triemstra Branch: branches/reactor-run-samples-754
branch-diff, diff-cov, branch-cov, buildbot
Author: thijs

Description


Change History (10)

comment:1 Changed 16 years ago by dpollet

Most examples not using reactor.run() (eg. doc/examples/emailserver.py) just
create a TCPServer and add it to an application. Maybe they lack a comment
pointing to twistd if they won't run by just loading them with python ?

In fact what I was initially searching for was a way to use reactor.callLater
while having a TCPserver running... had to ditch the code using reactor and
setup a TimerService instead, using mktap and twistd. From my beginner point of
view, the two approaches look incompatible, which feels strange...

-- cDlm from #twisted

comment:2 Changed 16 years ago by spiv

FWIW, I've already fixed doc/mail/examples/emailserver.py (it's location in SVN)
to have a short comment explaining how to run it.

It's probably worth looking at each file in doc/, though, and checking that all
valid TAC files (i.e. ones that can be used with twistd -y) are clearly marked
as such for newbies.

comment:3 Changed 14 years ago by hypatia

Cc: hypatia removed
Component: core
Keywords: core removed
Owner: changed from hypatia to edsuom

comment:4 Changed 12 years ago by Thijs Triemstra

Cc: Thijs Triemstra added
Owner: changed from edsuom to Thijs Triemstra
Status: newassigned

comment:5 Changed 12 years ago by Thijs Triemstra

author: thijs
Branch: branches/reactor-run-samples-754

(In [24569]) Branching to 'reactor-run-samples-754'

comment:6 Changed 12 years ago by Thijs Triemstra

Keywords: review added
Owner: Thijs Triemstra deleted
Status: assignednew

comment:7 Changed 12 years ago by radix

Keywords: review removed
Owner: set to Thijs Triemstra

The only problem is the use of the word "module". Since they're .tac files, they're not importable, therefore they're not modules. Can you change it to ".tac file" or "file"?

Once you do that, feel free to merge.

comment:8 in reply to:  7 Changed 12 years ago by Thijs Triemstra

Status: newassigned

Replying to radix:

The only problem is the use of the word "module". Since they're .tac files, they're not importable, therefore they're not modules. Can you change it to ".tac file" or "file"?

Once you do that, feel free to merge.

Alright, I changed it to '.tac file' in r24615

comment:9 Changed 12 years ago by Thijs Triemstra

Resolution: fixed
Status: assignedclosed

(In [24616]) Merge reactor-run-samples-754: adding a note for newbies to all .tac samples, explaining how to run the file with twistd.

Author: thijs Reviewer: radix Fixes: #754

comment:10 Changed 9 years ago by <automation>

Owner: Thijs Triemstra deleted
Note: See TracTickets for help on using tickets.