Opened 4 years ago

Closed 4 years ago

#7526 enhancement closed fixed (fixed)

twisted/conch/avatar.py doesn't match twisted coding standards

Reported by: Alex Gaynor Owned by: Ying Li
Priority: normal Milestone: Python-3.x
Component: core Keywords:
Cc: Branch: branches/small-conch-cleanup-7526
branch-diff, diff-cov, branch-cov, buildbot
Author: cyli

Description

Notably:

  • It uses implicit relative imports
  • It uses zope.interface.implements instead of implementer
  • It fails to place a between a , and an argument in a function call.

(Marking as a Python3 ticket due to the first two points)

Change History (5)

comment:1 Changed 4 years ago by Alex Gaynor

Keywords: review added

comment:2 Changed 4 years ago by Ying Li

Owner: set to Ying Li

comment:3 Changed 4 years ago by Ying Li

Author: cyli
Branch: branches/small-conch-cleanup-7526

(In [42792]) Branching to small-conch-cleanup-7526.

comment:4 Changed 4 years ago by Ying Li

Keywords: review removed

Thanks for working on this Alex! I added a misc topfile corresponding to this ticket number, other than that it looks great.

Here are the buildbot test results: https://buildbot.twistedmatrix.com/boxes-supported?branch=/branches/small-conch-cleanup-7426

(Ignore the bad ticket number on that link - I previously created a branch with the wrong ticket number, but it was the same cherry-picked commit).

comment:5 Changed 4 years ago by Ying Li

Resolution: fixed
Status: newclosed

(In [42795]) Merge small-conch-cleanup-7526: Small twisted coding-standard changes in conch

Author: Alex Reviewers: cyli Fixes: #7526

A couple of small changes to make twisted.conch.avatar more compliant with the twisted coding standard. This also happens to make it more python3-compatible.

Note: See TracTickets for help on using tickets.