Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#7335 task closed fixed (fixed)

Release Twisted 15.0

Reported by: hawkowl Owned by: hawkowl
Priority: normal Milestone:
Component: release management Keywords:
Cc: radix Branch: branches/releases/release-15.0.0-7335
branch-diff, diff-cov, branch-cov, buildbot
Author:

Description (last modified by hawkowl)

Onwards to -14.1- 15.0!

Change History (21)

comment:1 Changed 5 years ago by DefaultCC Plugin

Cc: radix added

comment:2 Changed 5 years ago by hawkowl

Owner: set to hawkowl

comment:3 Changed 5 years ago by hawkowl

Description: modified (diff)
Summary: Release Twisted 14.1Release Twisted 15.0

comment:4 Changed 5 years ago by hawkowl

Branch: branches/releases/release-15.0.0-7335

comment:5 Changed 5 years ago by hawkowl

Keywords: review added

*does celebration trombones* review please!

comment:6 Changed 5 years ago by Adi Roiban

I took a look at diff and it looks good. Thanks!

comment:7 Changed 5 years ago by hawkowl

Owner: hawkowl deleted

comment:8 Changed 5 years ago by Glyph

Keywords: review removed
Owner: set to hawkowl

The release notes for 14.0.1 and 14.0.2 should really be merged in here, since from a user's perspective there is a linear timeline of features here. I guess that means this will need one more cycle of review. Sorry :-\.

comment:9 Changed 5 years ago by hawkowl

Keywords: review added
Owner: hawkowl deleted

Merged in the changelogs.

comment:10 Changed 5 years ago by Jean-Paul Calderone

The release notes for 14.0.1 and 14.0.2 should really be merged in here

Is that a documented part of the release process?

comment:11 in reply to:  10 Changed 5 years ago by hawkowl

Replying to exarkun:

The release notes for 14.0.1 and 14.0.2 should really be merged in here

Is that a documented part of the release process?

I'm not sure. They *should* have been there already (since releases "should" be merged into trunk), but the original idea was that 14.0.2 was a hotfix, and 14.1/15.0 would include an entirely different fix than 14.0.2 did. But... it didn't, and in merging the changelogs I opted to have 14.0.1/2 as what was released, and everything else was in 15.0.

How should we handle this possible divergence next time? What's a fix, and what is fixed in trunk, may be different, and so a x.y.1 may be an entirely different "line" of versions than x.y+1.0. But, version numbers are supposed to exist on a concurrent plane... I'm not sure.

comment:12 Changed 5 years ago by Jean-Paul Calderone

But... it didn't, and in merging the changelogs I opted to have 14.0.1/2 as what was released, and everything else was in 15.0.

I don't understand this. You merged 14.0.1 and 14.0.2 into trunk? Into the 15.0 release branch? And resolved conflicts in the news files?

comment:13 in reply to:  12 Changed 5 years ago by hawkowl

Replying to exarkun:

But... it didn't, and in merging the changelogs I opted to have 14.0.1/2 as what was released, and everything else was in 15.0.

I don't understand this. You merged 14.0.1 and 14.0.2 into trunk? Into the 15.0 release branch? And resolved conflicts in the news files?

I copied in the 14.0.1/14.0.2 news file entries (manually) into the release branch's notes.

comment:14 Changed 5 years ago by Jean-Paul Calderone

So by "should have been there" you didn't mean you expected them to be there. Instead, you meant that the normal release process would have caused them to be there but the 14.0.1 and 14.0.2 releases didn't follow the normal release process?

comment:15 in reply to:  14 Changed 5 years ago by hawkowl

Replying to exarkun:

So by "should have been there" you didn't mean you expected them to be there. Instead, you meant that the normal release process would have caused them to be there but the 14.0.1 and 14.0.2 releases didn't follow the normal release process?

Yeah, 14.0.1 and 14.0.2 didn't follow it -- there weren't prereleases or reviews prior to getting a fix deployed, and it didn't get merged in as the problem that was fixed was put in a ticket to make it into trunk. I think what happens in a security fix situation (of which this seemed to be the first one, or at least the only one since 2008, looking at https://twistedmatrix.com/Releases/) needs to be written down, so what to do in this situation has a clear answer, and isn't something we're sorting out in the review stage.

comment:16 Changed 5 years ago by Jean-Paul Calderone

Can you write down what was done and the associated problems?

comment:17 Changed 5 years ago by hawkowl

Sure. Is this a release blocker, or something I should do after 15.0 is out the door?

comment:18 in reply to:  17 Changed 5 years ago by Glyph

Replying to hawkowl:

Sure. Is this a release blocker, or something I should do after 15.0 is out the door?

It's not a blocker - release blockers are for things that somehow threaten the quality of the release (regressions, pretty much), and the output here is a small amount of prose in some text files we can easily manually verify.

This isn't even a case of parts of the release process being undocumented and secret and thereby broken: 14.0.1 and 2 were anomalous releases, done under a sort of pilot release program for security updates, and maybe not even done in the best way. The worst case scenario of not documenting this is that we will have to do all the work to figure out a viable security release process again from scratch, and maybe we have to do that anyway.

Nevertheless, the postmortem should totally be done, though, because we should have a totally seamless process for that in the future which should not necessitate manual editing.

comment:19 Changed 5 years ago by Glyph

Keywords: review removed
Owner: set to hawkowl

And, speaking of manually reviewing that prose, i've now done so. I did some experiments building locally, I see a happy buildbot, I think we are good to go for fifteen dot oh.

 ____  _   _ ___ ____    ___ _____ 
/ ___|| | | |_ _|  _ \  |_ _|_   _|
\___ \| |_| || || |_) |  | |  | |  
 ___) |  _  || ||  __/   | |  | |  
|____/|_| |_|___|_|     |___| |_|  

comment:20 Changed 5 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [43795]) Merge releases/release-15.0.0-7335: Release Twisted 15.0.0

Author: hawkowl Reviewer: glyph Fixes: #7335

comment:21 Changed 4 years ago by hawkowl

Milestone: Twisted 14.1.0

Ticket retargeted after milestone deleted

Note: See TracTickets for help on using tickets.