Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#7333 defect closed fixed (fixed)

Trove classifiers are incorrect

Reported by: Hynek Schlawack Owned by: Jean-Paul Calderone
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/setup3-same-classifiers-7333
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

https://pypi.python.org/pypi/Twisted/14.0.0 still says

    Programming Language :: Python :: 2.6
    Programming Language :: Python :: 2.7
    Programming Language :: Python :: 2 :: Only

which is kind of unfortunate.

Turns out, we’re still setting the 3.3 classifier in setup3.py which is wrong. The metadata must be consistent for all versions.

Change History (9)

comment:1 Changed 6 years ago by Itamar Turner-Trauring

Milestone: Twisted 14.1.0

comment:2 Changed 5 years ago by Jean-Paul Calderone

Owner: set to Jean-Paul Calderone

https://pypi.python.org/pypi/Twisted/14.0.0 still says

As far as I can tell, as setup.py is now, this will be fixed in 14.1.0 (check setup.py --classifiers). This was fixed as part of #6539.

Turns out, we’re still setting the 3.3 classifier in setup3.py which is wrong. The metadata must be consistent for all versions.

I'm not clear on this part though. I guess you want that classifier deleted from setup3.py? I don't think it actually makes a difference because we don't do releases with setup3.py. But deleting it is super easy I guess so ...

comment:3 Changed 5 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/setup3-same-classifiers-7333

(In [43050]) Branching to 'setup3-same-classifiers-7333'

comment:4 Changed 5 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to Glyph

comment:5 Changed 5 years ago by khorn

Keywords: review removed
Owner: changed from Glyph to khorn

comment:6 Changed 5 years ago by khorn

Looks good to me. Merge it.

Shortest review ever?

comment:7 Changed 5 years ago by khorn

Owner: changed from khorn to Jean-Paul Calderone

comment:8 Changed 5 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [43059]) Merge setup3-same-classifiers-7333

Author: exarkun (sponsored by Hybrid Logic, Ltd.) Reviewer: khorn Fixes: #7333

Remove the trove classifier override in the Python 3 distutils entrypoint. This makes the classifiers consistent whether Python 2 or Python 3 is being used.

comment:9 Changed 4 years ago by hawkowl

Milestone: Twisted 14.1.0

Ticket retargeted after milestone deleted

Note: See TracTickets for help on using tickets.