Opened 8 years ago

Last modified 8 years ago

#7134 defect new

The service_identity unimportable warning omits spaces between several words

Reported by: habnabit Owned by: habnabit
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/add-some-spaces-7134
branch-diff, diff-cov, branch-cov, buildbot
Author: habnabit

Description

"Without the service_identity module and a recent enough pyOpenSSL tosupport it, Twisted can perform only rudimentary TLS client hostnameverification. Many valid certificate/hostname mappings may be rejected."

Presumably this should be "to support" and "hostname verification" rather than without the spaces.

Change History (5)

comment:1 Changed 8 years ago by habnabit

Author: habnabit
Branch: branches/add-some-spaces-7134

(In [42196]) Branching to 'add-some-spaces-7134'

comment:2 Changed 8 years ago by habnabit

(In [42197]) Add some spaces to a warning string. refs #7134

comment:3 Changed 8 years ago by habnabit

Keywords: review added
Owner: habnabit deleted

Buildbot is running, but I highly doubt that this is going to fail in any way.

comment:4 Changed 8 years ago by Julian Berman

Keywords: review removed
Owner: set to habnabit

Hooray string concat.

Pending the imminent greens, looks good to me.

comment:5 Changed 8 years ago by Alex Gaynor

Green. Shipit.

Note: See TracTickets for help on using tickets.