Opened 5 years ago
Closed 4 years ago
#7083 enhancement closed fixed (fixed)
Update echoserv_ssl.py to use react
Reported by: | Jean-Paul Calderone | Owned by: | hawkowl |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | core | Keywords: | documentation |
Cc: | Mike Cooper | Branch: |
branches/echoserv-ssl-react-7083
branch-diff, diff-cov, branch-cov, buildbot |
Author: | hynek |
Description
"Single shot" clients like this one - which perform some well-defined operation with a clear completion condition - should use twisted.internet.task.react
.
Attachments (2)
Change History (13)
comment:1 Changed 5 years ago by
Cc: | Mike Cooper added |
---|---|
Owner: | set to Mike Cooper |
Status: | new → assigned |
comment:2 Changed 5 years ago by
Changed 5 years ago by
Attachment: | echoserv-react.patch added |
---|
comment:3 Changed 5 years ago by
Keywords: | review added |
---|---|
Owner: | Mike Cooper deleted |
Status: | assigned → new |
Assuming that the point of this was to fix the clients, I did that.
comment:4 Changed 5 years ago by
Keywords: | review removed |
---|---|
Owner: | set to Mike Cooper |
Thanks for the contribution! There's a few minor issues with it.
- You appear to have an extra bit in your diff that's not related to the fix, patching _sslverify.
- All changes need a news file.
- You call
self.done.errback(None)
, which will fail, because there is no current exception whenclientConnectionFailed
is called. You might mean insteadself.done.callback(None)
orself.done.errback(reason)
comment:5 Changed 5 years ago by
Keywords: | review added |
---|---|
Owner: | Mike Cooper deleted |
Fixed issues pointed out in comment 4.
comment:7 Changed 4 years ago by
Author: | → hynek |
---|---|
Branch: | → branches/echoserv-ssl-react-7083 |
(In [43346]) Branching to echoserv-ssl-react-7083.
comment:8 Changed 4 years ago by
comment:9 Changed 4 years ago by
Owner: | set to hawkowl |
---|
Turns out™ echoclient_ssl.py has already been ported over, but echoclient.py itself not.
So I applied what worked and added some prettifications to it to adhere to our standards. Keeping it in review, so someone (an owl volunteered) can double-check my changes.
comment:11 Changed 4 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Replying to exarkun:
In the subject you said "Update echoserv_ssl.py", but in the description you said "clients like this". Are you talking about "echoclient_ssl.py" instead?