Opened 4 years ago

Closed 4 years ago

#6907 enhancement closed fixed (fixed)

Deprecate Lore

Reported by: khorn Owned by: hawkowl
Priority: normal Milestone: Twisted-14.0.0
Component: lore Keywords:
Cc: Branch: branches/deprecate-lore-6907
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl


As Twisted has switched to using Sphinx for generating documentation, Lore is no longer needed, and should be deprecated.

Once Lore has been deprecated, and is no longer needed, another ticket should be created to remove it.


Change History (5)

comment:1 Changed 4 years ago by hawkowl

Author: hawkowl
Branch: branches/deprecate-lore-6907

(In [41772]) Branching to deprecate-lore-6907.

comment:2 Changed 4 years ago by hawkowl

Keywords: review added

I've taken a stab at deprecating it.

comment:3 Changed 4 years ago by Adi Roiban

Looks good to me. Thanks! Buildbot test are not available.

comment:4 Changed 4 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to hawkowl


  1. I'm not sure I see the benefit of deleting the TODO comment in twisted/lore/ as part of this change.
  2. I've tried to figure out why this module uses unittest.TestCase but I can't. I don't think the module should use *both* unittest.TestCase *and* twisted.trial.unittest.TestCase. One thing I do see is that the existing twisted imports in this test module are a subset of the imports in twisted/ I don't see how that could actually matter in this case though. I suspect since all the tests pass even with the new twisted.trial.unittest import it's safe to switch this code entirely over to trial. Also, please use the from twisted.trial.unittest import TestCase style of import.
  3. You might like namedAny("twisted.lore") or maybe just __import__("twisted.lore") to avoid needing to hack around pyflakes warnings.
  4. American English spelling, sorry! favor instead of favour.
  5. There's no standard (maybe there should be) for this but consider:
    exarkun@top:~/Projects/Twisted/trunk$ grep "was deprecated" twisted/ -r --include '*.py' | wc -l
    exarkun@top:~/Projects/Twisted/trunk$ grep "is deprecated" twisted/ -r --include '*.py' | wc -l

Thanks again. Please merge after addressing those points.

comment:5 Changed 4 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [41790]) Merge deprecate-lore-6907: Deprecate Twisted Lore

Author: hawkowl Reviewer: exarkun Fixes: #6907

This deprecates Twisted Lore, in favor of using Sphinx, from Twisted 14.0.

Note: See TracTickets for help on using tickets.