Opened 8 years ago

Closed 7 years ago

#6810 task closed fixed (fixed)

Deprecate twisted.protocols.gps

Reported by: Thijs Triemstra Owned by: hawkowl
Priority: lowest Milestone:
Component: core Keywords:
Cc: Branch: branches/deprecate-tprotocolsgps-6810
branch-diff, diff-cov, branch-cov, buildbot
Author: hawkowl

Description (last modified by hawkowl)

(hawkowl note: all of twisted.protocols.gps should be deprecated because twisted.positioning is now here)

[source:trunk/twisted/protocols/gps/rockwell.py] was added 9 years ago (r4528) but never received any unit tests. Since then it was updated a few times (removing imports, adding license header) but unit tests were never added. #6565 replaces usage of reduce in twisted core and also touches rockwell.py.

Because there are no existing tests, and interest for this protocol (from 1996) seems non-existent, we are going to deprecate it.

Change History (6)

comment:1 Changed 8 years ago by Thijs Triemstra

Also see #3926 for twisted.positioning, "a better positioning framework" in the making.

comment:2 Changed 7 years ago by hawkowl

Author: hawkowl
Branch: branches/deprecate-tprotocolsgps-6810

(In [44515]) Branching to deprecate-tprotocolsgps-6810.

comment:3 Changed 7 years ago by hawkowl

Description: modified (diff)
Summary: Deprecate twisted.protocols.gps.rockwellDeprecate twisted.protocols.gps

comment:4 Changed 7 years ago by hawkowl

Keywords: review added

Changes made, builders spun, please review.

comment:5 Changed 7 years ago by Adi Roiban

Keywords: review removed
Owner: set to hawkowl

Changes looks good to help.

Please fix the twistedchecker error and merge.

Thanks!

comment:6 Changed 7 years ago by hawkowl

Resolution: fixed
Status: newclosed

(In [44522]) Merge deprecate-tprotocolsgps-6810: Deprecate twisted.protocols.gps

Author: hawkowl Reviewer: adiroiban Fixes: #6810

Note: See TracTickets for help on using tickets.