Changes between and of Version 2Version 3Ticket #6782


Ignore:
Timestamp:
10/09/2013 05:04:42 PM (7 years ago)
Author:
Jean-Paul Calderone
Comment:

Thanks.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6782 – Description

    v2 v3  
    1010    SSL_do_handshake().
    1111
    12 The code in `twisted.protocols.tls` is completely wrong, and I suspect that it only works at all because OpenSSL is buggy.  If we fix it, then it becomes possible to fix #6204 (because we'll actually know when the handshake is done) and we can actually report handshake errors correctly (although getting them logged in, say, a web server will require forwarding them to the underlying protocol).
     12The code in `twisted.protocols.tls` is completely wrong, and I suspect that it only works at all because OpenSSL is buggy.  If we fix it, then it becomes possible to fix #6024 (because we'll actually know when the handshake is done) and we can actually report handshake errors correctly (although getting them logged in, say, a web server will require forwarding them to the underlying protocol).
    1313
    1414Here's a partial fix.  It appears to work.  I don't know how to write test cases for it without resorting to some kind of end-to-end test.