Opened 8 years ago

Last modified 8 years ago

#6737 defect new

conch should use DISCONNECT_BY_APPLICATION reason when closing ssh connection

Reported by: Andriy Gapon Owned by:
Priority: normal Milestone:
Component: conch Keywords:
Cc: z3p Branch:
Author:

Description

conch should use DISCONNECT_BY_APPLICATION reason when closing ssh connection as opposed to the currently used DISCONNECT_CONNECTION_LOST: http://twistedmatrix.com/trac/browser/trunk/twisted/conch/ssh/transport.py#L811

Most obviously that should be in line with the provided human friendly description: "user closed connection" (I assume that application and user are interchangeable here).

Then, DISCONNECT_CONNECTION_LOST implies that a connection was "lost" as opposed to be explicitly closed by one of the parties. It is not clear how the connection is lost.

And most importantly, the current reason code causes rather annoying spamming in OpenSSH sshd's logs. Please see the following code: http://bxr.su/OpenBSD/usr.bin/ssh/packet.c#1455 Currently it leads to the following "errors" being logged: sshd[46053]: error: Received disconnect from x.x.x.x: 10: user closed connection

Change History (1)

comment:1 Changed 8 years ago by DefaultCC Plugin

Cc: z3p added
Note: See TracTickets for help on using tickets.