Opened 3 years ago

Closed 3 years ago

#6720 enhancement closed fixed (fixed)

DeferredFilesystemLock should return a cancellable Deferred

Reported by: Glyph Owned by: Kai Zhang
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/deferredfilesystemlock-cancellation-6720
branch-diff, diff-cov, branch-cov, buildbot
Author: kaizhang

Description

It already implements its own timeout internally; it would be nice if you could trigger this in advance. (Maybe this could even be refactored to use generic timeout support!)

Change History (5)

comment:1 Changed 3 years ago by Kai Zhang

Status: newassigned

comment:2 Changed 3 years ago by Kai Zhang

Author: kaizhang
Branch: branches/deferredfilesystemlock-cancellation-6720

(In [39907]) Branching to 'deferredfilesystemlock-cancellation-6720'

comment:3 Changed 3 years ago by Kai Zhang

Keywords: review added
Owner: Kai Zhang deleted
Status: assignednew

comment:4 Changed 3 years ago by Tom Prince

Keywords: review removed
Owner: set to Kai Zhang

Thanks. One minor point of grammar: "When cancelling" not "When cancel". Please merge after fixing that.

comment:5 Changed 3 years ago by itamarst

Resolution: fixed
Status: newclosed

(In [40558]) Merge deferredfilesystemlock-cancellation-6720: DeferredFilesystemLock supports Deferred cancellation.

Author: kaizhang Reviewer: tom.prince Fixes: #6720

The Deferred returned by twisted.internet.defer.DeferredFilesystemLock.deferUntilLocked can now be cancelled.

Note: See TracTickets for help on using tickets.