Opened 3 years ago

Closed 6 weeks ago

#6712 enhancement closed fixed (fixed)

Use HostnameEndpoint with Agent

Reported by: Itamar Turner-Trauring Owned by: Glyph
Priority: normal Milestone:
Component: web Keywords:
Cc: ashfall, jknight, lukasaoz@… Branch: hostagent-6712-3
branch-diff, diff-cov, branch-cov, buildbot
Author: glyph

Description

Agent should use HostnameEndpoint to get IPv6 support. This may necessitate another ticket for the SSL path...

Change History (16)

comment:1 Changed 3 years ago by DefaultCC Plugin

Cc: jknight added

comment:2 Changed 3 years ago by Jean-Paul Calderone

What is the "SSL path"?

comment:3 Changed 3 years ago by Jean-Paul Calderone

Owner: set to Itamar Turner-Trauring

comment:4 Changed 3 years ago by Jean-Paul Calderone

Oh, I bet you're referring to https://twistedmatrix.com/trac/ticket/5642

comment:5 Changed 11 months ago by Glyph

#5642 is now closed, so we are ready to do this.

comment:6 Changed 11 months ago by Glyph

Author: glyph
Branch: branches/hostagent-6712

(In [46787]) Branching to hostagent-6712.

comment:7 Changed 11 months ago by Glyph

Author: glyph
Branch: branches/hostagent-6712

There's a branch with what I think is a basically correct implementation, but the existing tests need a bunch of maintenance. Finishing up #4362 would be a good way to get started on that.

comment:8 Changed 11 months ago by Glyph

Author: glyph
Branch: branches/hostagent-6712

comment:9 Changed 7 months ago by Glyph

Branch: branches/hostagent-6712hostagent-6712

comment:10 Changed 7 months ago by Glyph

Branch: hostagent-6712hostagent-6712-2

comment:11 Changed 7 months ago by Cory Benfield

Cc: lukasaoz@… added

comment:12 Changed 6 weeks ago by Glyph

Branch: hostagent-6712-2hostagent-6712-3

#4362 is, indeed, finished! As a result, there is now a branch which uses it to make the testing more deterministic.

comment:13 Changed 6 weeks ago by Glyph

Keywords: review added

And I believe it's ready for review (although we'll see what CI thinks, I suppose)

https://github.com/twisted/twisted/pull/624

comment:14 Changed 6 weeks ago by Glyph

Owner: Itamar Turner-Trauring deleted

comment:15 Changed 6 weeks ago by itamarst

Keywords: review removed
Owner: set to Glyph

comment:16 Changed 6 weeks ago by Glyph <glyph@…>

Resolution: fixed
Status: newclosed

In 63dc038:

Merge pull request #624 from twisted/hostagent-6712-3

Author: glyph

Reviewer: itamarst

Fixes: ticket:6712

twisted.web.client.Agent now uses HostnameEndpoint internally; as a consequence, it now supports IPv6, as well as making connections faster and more reliably to hosts that have more than one DNS name.

Note: See TracTickets for help on using tickets.