Opened 7 years ago

Closed 6 years ago

#6707 task closed fixed (fixed)

Remove deprecated t.python.util.unsignedID and setIDFunction

Reported by: Thijs Triemstra Owned by: Jean-Paul Calderone
Priority: low Milestone:
Component: core Keywords:
Cc: Thijs Triemstra Branch: branches/unsigned-id-removal-6707
branch-diff, diff-cov, branch-cov, buildbot
Author: ewong

Description

unsignedID and setIDFunction in [source:trunk/twisted/python/util.py] have been deprecated since 13.0 and can be removed in an upcoming release.

Discovered as part of the Python 2.5 code review ticket (#5715).

Attachments (1)

6707.patch (5.4 KB) - added by Edmund Wong 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Edmund Wong

Attachment: 6707.patch added

comment:1 Changed 7 years ago by Edmund Wong

Keywords: review added

comment:2 Changed 7 years ago by Tom Prince

Note that this can't be merged until at least 14.0, since it hasn't yet been a year since they were deprecated. 13.0 was released 2013-03-19.

comment:3 Changed 7 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/unsigned-id-removal-6707

(In [41028]) Branching to 'unsigned-id-removal-6707'

comment:4 Changed 7 years ago by Jean-Paul Calderone

Author: exarkunthijs

comment:5 Changed 6 years ago by Thijs Triemstra

Author: thijsewong
Keywords: review removed
Owner: set to Jean-Paul Calderone

Thanks. There are 2 private vars left that only seem to be used by the removed functions:

  • _idFunction
  • _HUGEINT

Please remove those as well and merge.

comment:6 Changed 6 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [41206]) Merge unsigned-id-removal-6707

Author: ewong Reviewer: thijs Fixes: #6707

Remove twisted.python.util.unsignedID and twisted.python.util.setIDFunction, deprecated since 13.0.

Note: See TracTickets for help on using tickets.