Opened 8 years ago
#6604 task new
Remove twisted.names.resolve.ResolverChain.lookupAllRecords
| Reported by: | Richard Wall | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | names | Keywords: | |
| Cc: | Branch: | ||
| Author: |
Description
In #5992 I noticed that twisted.names.resolve.ResolverChain overrides lookupAllRecords, but it seems to be unnecessary.
The reason may originally have been that twisted.names.cache overrides lookupAllRecords and it was important for ResolverChain to call the overridden version.
But actually, dns.ALL_RECORDS queries can be handled just the same as any other type by ResolverChain._lookup.
ResolverChain._lookup will call cache.Resolver.query which will correctly dispatch to cache.Resolver.lookupAllRecords.
If I remove ResolverChain.lookupAllRecords, all names tests still pass.
See:
Note: See
TracTickets for help on using
tickets.