#6547 defect new
Class mail.pb.MaildirBroker apparently broken and obsolete
|Reported by:||mulhern||Owned by:||radix|
branch-diff, diff-cov, branch-cov, buildbot
This class appears to be broken and obsolete. Here are the reasons:
1) No unit tests. 2) Last change to the file was two years ago. 3) Most recent update to code in this class is revision 581. 4) Running either of the two methods getCollections or proto_getCollections on a MaildirBroker object results in an AttributeError. The attribute errors indicate that the field "domains" or the field "_getCollection" do not exist in the object. 5) No occurrences of the name MaildirBroker exist anywhere else in the codebase.
Note: MaildirBroker extends spread.pb.Broker which extends spread.banana.Banana which extends (internet.protocol.BaseProtocol which extends internet.protocol.Protocol) and twisted.styles.Ephemeral but not of these seem to define the missing fields.
Attached a unit test file which demonstrates the error by succeeding. It should be placed in the twisted/mail/test directory.
Change History (15)
comment:4 Changed 4 years ago by
|Owner:||changed from mulhern to Thijs Triemstra|
comment:8 Changed 4 years ago by
|Author:||mulhern → radix, mulhern|